more fixes#1040
Merged
Merged
Conversation
henrydingliu
requested review from
genedan,
jbogaardt and
kennethshsu
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## disposal_rate_method #1040 +/- ##
========================================================
+ Coverage 89.24% 89.27% +0.03%
========================================================
Files 91 91
Lines 5233 5233
Branches 666 666
========================================================
+ Hits 4670 4672 +2
+ Misses 396 393 -3
- Partials 167 168 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Changes disposal-rate estimation math in fit(), which drives forecast patterns and full_triangle_; scope is small but actuarially meaningful.
Overview
DisposalRate.fitnow converts the input triangle to cumulative (incr_to_cum()) before buildingdisposal_rate_triand the internalX_used for development weighting, so disposal rates are cumulative loss ÷ ultimate even when callers pass incremental data.The sparse
test_sparse_transformkeepssample_weighton the sparse backend explicitly when callingfit_transform, matching how production sparse pipelines should pass ultimates.Reviewed by Cursor Bugbot for commit 6eb6afd. Bugbot is set up for automated code reviews on this repo. Configure here.